Skip to content

Remove unused required prop in a component

Alexander Turinske requested to merge remove-unused-prop into master

What does this MR do?

Remove unused required prop in a component

  • fixes console error from a required prop not being passed in

Prop history

  • the prop was added in a767966d
  • the prop and the usage of it was removed in 2d24c1d4, but the prop was not removed from the tests
  • the prop was added back in d463a5ab, but not added with any usage. I suspect it was because the tests still had the prop in it.

How to reproduce

https://gitlab.com/snippets/1956676

Screenshots

Old After
Screen_Shot_2020-07-31_at_3.26.32_PM Screen_Shot_2020-07-31_at_3.23.44_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alexander Turinske

Merge request reports

Loading