Skip to content

SSH Key E2E updates

Mark Lapierre requested to merge ml-update-ssh-key-test-resource-rake-task into master

What does this MR do?

  • In browser_ui/3_create/repository/ssh_key_support_spec.rb check for the full key title. This makes the error message clearer if the test fails.
  • Expire keys automatically when created via the API (like they already were when created via the UI).
  • Add the dry_run rake task param

FYI I'm adding documentation about the rake task in gitlab-com/www-gitlab-com!58434 (merged)

See #233238 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mark Lapierre

Merge request reports

Loading