Skip to content

Fill out response from CoverageReportsController

drew stachon requested to merge group-coverage-reporting-csv into master

What does this MR do?

This merge request send a query to the Ci::DailyBuildGroupReportResultsByGroupFinder and returns a CSV response. This will be used in Group Analytics, a premium feature.

The controller with licensing and permissions implementations was merged in an earlier MR !37154 (merged), and this only adds data to the successful index response.

The new Finder is introduced in !37768 (merged), and this merge request will pass CI once that is merged and this is rebased.

The CI-related permissions for allowing particular coverage data to be included is set by a new group-level permission in !37768 (merged).

The structure is based on the existing Ci::DailyBuildGroupReportResultsController, along with the corresponding spec. I've tried to change as little as possible, leaving us the opportunity to consolidate reporting functionalities in the future.

I haven't added documentation for this because it's only intended to support an internal feature, not be exposed publicly. This API will be made available as a feature with GraphQL

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • ~~Label as security and @ mention @gitlab-com/gl-security/appsec~~
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by drew stachon

Merge request reports

Loading