Remove external url data from props in favor of store
What does this MR do?
Remove external url data from props in favor of using store properties
As we want to allow users to switch between dashboard dynamically, we should remove fixed props that a set from the HTML in favor of a dynamic data that is fetched later in the execution.
Screenshots
A small smoke test, I added a an External URL in the configuration at Settings -> Operations:
The external dashboard button is present at http://127.0.0.1:3000/root/autodevops-deploy/-/metrics/
:
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #229709 (closed)
Edited by Miguel Rincon