Skip to content

Stop using weight and priority keys in metrics dashboards

Reuben Pereira requested to merge 209243-remove-priority-weight into master

What does this MR do?

Stop using weight and priority keys in metrics dashboards. Panels and groups will now appear on dashboards in the order they are defined. This should make the order of panels in a dashboard easier to predict and understand.

Custom metrics (PrometheusMetric model) groups ("system", "response" and "business") have a hardcoded priority, which is used to ensure that custom metric groups always appear in the same order. This priority will not be removed since custom metrics are not defined in a dashboard yaml file. They are injected into the common_metrics dashboard. So we still need to know their priority to determine in what order the custom metrics should appear in the dashboard.

Issue: #209243 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Reuben Pereira

Merge request reports

Loading