Fix vertical alignment of svg icons on Jobs page
requested to merge 233426-https-gitlab-com-gitlab-org-gitlab-merge_requests-38059-causing-icons-to-be-misaligned-on into master
What does this MR do?
Issue #233426 (closed)
Since we are now using vertical-align
on these icons, the fix with position: relative
and top: 2px
is no longer needed.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #233426 (closed)
Edited by Justin Ho Tuan Duong