Stub feature flags earlier
What does this MR do?
Feature flags are stubbed as true by default during tests. The stub creation can occur after spec code has already executed.
The rspec callback hooks are executed in the following order:
- before :suite
- before :context
- before :example
- after :example
- after :context
- after :suite
Prior to this MR the feature flags are stubbed at 3. before :example. Leaving room for code to execute unstubbed in 1. before :suite and 2. before :context.
In practical terms, any let_it_be definitions will occur in 2. before :context and will not be stubbed. I was tripped up when my after_create was called as a result of let_it_be and the feature flag was disabled.
This MR stubs all feature flags to true before any spec code can execute.
We can not use rspec mock mechanisms earlier than they are already used. Therefore this MR has added stubbing with pure ruby.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team