New Package details UI
What does this MR do?
This MR moves the installation command to his new UI place, it also removes all the old code ( that was building the old UI ) and removes all the dead code.
It also removes the Files table
if the package is of type composer
( because they do not have any file associated )
It also removes the feature flag altogether
Change | Mr |
---|---|
Add feature flag and new History Component | !38045 (merged) |
Add additional metadata component | !38285 (merged) |
Move the installation commands to the center column, remove the feature flag and clean up old code |
|
As an experimental process, I would like to appoint a single reviewer and a single maintainer for all of the MRs, so that everyone has all the context.
- Reviewer: @oregand
- Maintainer @ntepluhina
How to test
To test this we will need to do some groundwork, luckily we can leverage the rails console for all of it:
rails c
p = Project.find(1)
FactoryBot.create(:npm_package, :with_build, project: p)
FactoryBot.create(:conan_package, project: p)
FactoryBot.create(:nuget_package, :with_metadatum, project: p)
FactoryBot.create(:maven_package, project: p)
FactoryBot.create(:pypi_package, project: p)
Feature.enable(:packages_details_one_column, p)
After this, the feature will be enabled on the project with id 1
( or any other selected on the second command ) and a npm, conan, nuget, maven and pypi package will be created.
Note that the packages created with FactoryBot have fake data inside that may not match with the 'real' one Note that the factories my fail, simply retrying the command ( even multiple time ) allows them to run
Screenshots
Maven | Conan | Nuget | Npm | Composer | PyPi |
---|---|---|---|---|---|
note: Composer does not have an installation instructions block yet, the installation instructions tabs will be removed in favor of a flat UI solution in a follow-up work
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Part of #227582 (closed)