Remove Icon component from vue_shared
What does this MR do?
Move GlIcon import from mixin to components
The vue_shared/mixins/related_issuable_mixin.js exposed a component import to the mixin consumers. This is a bad pattern, as there is a disconnect between templates of the components utilizing the mixin and the components they import. This is moving the import to the actual components.
Remove icon import from collapsible_sidebar
The collapsible sidebar is not utilizing the icon component at all.
During a refactor it was removed in
9fe79221, but due to a usage of the
dynamic component <component>, eslint doesn't complain.
Remove Icon component from vue_shared
We have replaced all of the usages of the icon component from vue_shared with GlIcon. It is time to remove it!
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team