[RUN-AS-IF-FOSS] Fix(filtered search manager): add state option
What does this MR do?
This MR fixes a bug by introducing a useStateDefault option to the legacy filtered_search_manager. This enables each usage to specify whether to use the default state setting as a part of the default search parameters.
Screenshots
Example where state=opened should be applied |
Example where state=opened should not be applied |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
The implemented fix does not have a difference for the usages that need this state=opened default behavior but requires these instances to specify to use this behavior via an option. This means that any missed uses will change to not have this behavior, which does involve some risk. However, I've gone through the code base pretty thoroughly to ensure we capture all instances. See my comment here: #232734 (comment 392352247).
The behavior is covered with tests and each of these instances should migrate away from this legacy filtered manager to use the more modern filtered_search_bar_root.vue. Efforts to do these migrations are captured in issues like this: #232465 (closed).
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #232734 (closed)