Add a fix for license_compliance_spec
What does this MR do?
Should fix #234068 (closed)
Intermittently it was observed that running the license_compliance_spec automated end to end spec against master would render a blank modal with no buttons to click.
This MR wraps the license click and has_element around the existing wait_until with a reload: true option in order to provide a retry.
Note that this was not observed when running through manual steps.
Screenshots
See #234068 (closed) for an example of the empty modal dialog.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
Ran through the test 10x against local branch (master + fix)
CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://{local_instance}:3000/ ./qa/specs/features/ee/browser_ui/secure/license_compliance_spec.rb
Observed the empty modal appear on a few executions, the test retried and was able to continue.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
/closes #234068 (closed)