Skip to content

Add more actions to and change UI of dashboard actions menu

Andrei Stoicescu requested to merge astoicescu/actions_menu_update into master

What does this MR do?

Changes the monitor dashboard actions menu as described in #228856 (closed)

Description

  • move "Star dashboard", "Add metric" and "Edit dashboard" inside of the actions menu
  • conditionally show and/or display a disabled (i.e. greyed out) state for some items in the actions menu based on the current dashboard being OOTB or custom
  • replace the current icon of the actions menu with a hamburger icon

Action menu item states

These are the states of the actions menu items based on whether the current dashboard is OOTB or custom.

Item Rendered Disabled Observations
Add metric OOTB n/a
Edit dashboard YAML OOTB/Custom OOTB This is rendered but disabled in OOTB in order to entice users to create a new dashboard and edit it
Duplicate current dashboard OOTB n/a In the future the Custom dashboards will also be duplicatable
Star dashboard OOTB/Custom n/a Text toggles between Star dashboard / Unstar dashboard
Create new dashboard OOTB/Custom n/a

Screenshots/videos

OOTB

Before

before_ootb before_menu_ootb

After

after_ootb after_menu_ootb

Custom

Before

before_custom before_menu_custom

After

after_custom after_menu_custom

Videos

OOTB dashboard Custom dashboard
Screen_Recording_2020-08-10_at_03.14.22 Screen_Recording_2020-08-10_at_03.08.11

This an Implementation issue for #220931 (closed). This issue is critical to allow us to implement add data to a custom dashboard, if designs need to be prioritized we should implement the custom dashboard actions first and OOTB dashboard second.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Andrei Stoicescu

Merge request reports

Loading