POC: Signup experiment cleanup
What does this MR do?
Part of gitlab-org/growth/engineering#5326 (closed)
TODO
-
Search for register-pane
in codebase and replace with registration path -
Make sure that sign in or trials didn't get affected -
Combine CE/EE welcome page https://gitlab.com/gitlab-org/gitlab/blob/nicolasdular/signup-experiment-cleanup/ee/app/views/registrations/welcome.html.haml#L24 if possible -
Make sure that we render brand_title
,brand_image
andbrand_text
on signup page -
Keep invite_email param when signing up
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular