Fix flaky test in spec/features/issues/gfm_autocomplete_spec.rb
What does this MR do?
This MR attempts to fix the flaky test in spec/features/issues/gfm_autocomplete_spec.rb — GFM autocomplete when tribute_autocomplete feature flag is on when other notes are destroyed keeps autocomplete key listeners.
The error, shown below, when testing emoji autocompletion suggests that the spec is invoking Enter before the autocomplete popup list appears. The solution is to wait for any requests to finish that the autocomplete is dependent on so that the popup then appears.
expected: "Hello :100: "
got: "Hello :10\n"I don't believe this MR needs a changelog since there are no UI/user-facing changes.
Issue: #231431 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team