Avoid using non-essential frequently-changing command
What does this MR do?
The dataloss command has been changed a few time recently, causing tests to fail that expected the behavior before the change. Most recently: gitaly!2449 (merged)
The dataloss command is not really required in this test to confirm when nodes are inconsistent. The rake 'replicas' task is enough for that. The command was included because it was useful to test that it performs as expected, but the test loses its value when the behavior under test changes so frequently.
This also fixes a problem in PraefectManager.replicated?
that caused the retry loop to end prematurely.
Closes #235179 (closed)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team