Remove not-null on type column in audit_events
What does this MR do?
Remove not-null constraint on type
column in audit_events
table.
We are in the process of moving away from STI model in AuditEvent and
dropping type
column. There is only one type (e.g. SecurityEvent
)
and this redundant column wastes precious storage.
Relates to #229914 (closed)
Databases
== 20200811055018 RemoveNotNullConstraintOnTypeFromAuditEvents: reverting =====
== 20200811055018 RemoveNotNullConstraintOnTypeFromAuditEvents: reverted (0.0000s)
== 20200811055018 RemoveNotNullConstraintOnTypeFromAuditEvents: migrating =====
-- change_column_null(:audit_events_part_5fc467ac26, :type, true)
-> 0.0030s
-- change_column_null(:audit_events, :type, true)
-> 0.0012s
== 20200811055018 RemoveNotNullConstraintOnTypeFromAuditEvents: migrated (0.0043s)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le