Skip to content

Add the ability to disable shared runners by group - UI

Payton Burdette requested to merge disable-shared-runners-ui into master

What does this MR do?

This MR adds the ability to disable shared runners on the group level.

UI can be found at Group > Settings > CI/CD > Expand Runner Settings

A user can now disable runners on a group level and subgroups/projects should follow the groups state. A top level group can allow the subgroup to override the top groups setting if the override toggle is set on the top level group.

Check out the screenshots below to get an idea of the state flow while reviewing this MR. 🙇

Screenshots

group subgroup
Screen_Shot_2020-10-02_at_10.09.36_AM Screen_Shot_2020-10-02_at_10.09.58_AM
Screen_Shot_2020-10-02_at_10.10.58_AM Screen_Shot_2020-10-02_at_10.11.21_AM
Screen_Shot_2020-10-02_at_10.11.53_AM Screen_Shot_2020-10-02_at_10.09.36_AM
group project
Screen_Shot_2020-10-02_at_10.11.53_AM Screen_Shot_2020-10-02_at_10.13.47_AM
Screen_Shot_2020-10-02_at_10.09.36_AM Screen_Shot_2020-10-02_at_10.14.27_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports

Loading