Skip to content

Centralise feature flag checking of on-demand DAST

What does this MR do?

at the moment, we have a catch-all ability that describes a user's ability to run an on-demand dast scan (run_ondemand_dast_scan). another ability (create_on_demand_dast_scan) was introduced to supersede it. the new ability has both a feature flag check and a feature availability check.

now that we've enable the feature flag by default (#237796 (closed), #235105 (closed)), having this functionality in a single place makes the feature flag easier to maintain and less error-prone.

i've also addressed some tech debt related to feature flags in our specs (specifically around feature flags).

Notes

  • we may split the catch-all ability up into more fine-grain abilities but, at present, there is no business need to have fine-grain control.

Related Issue(s)

#232348 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham

Merge request reports

Loading