Skip to content

Remove deprecated button in project_selector/project_list_item.vue

Marcin Sedlak-Jakubowski requested to merge msj-glbutton-219895 into master

What does this MR do?

Remove deprecated button and close #219895 (closed)

Screenshots

Resting before Selected before Focus before Hover before
Screen_Shot_2020-09-04_at_2.40.19_PM Screen_Shot_2020-09-04_at_2.40.37_PM Screen_Shot_2020-09-04_at_2.40.29_PM Screen_Shot_2020-09-04_at_2.40.25_PM
Resting after Selected after Focus after Hover after
Screen_Shot_2020-09-04_at_1.41.56_PM Screen_Shot_2020-09-04_at_1.42.03_PM Screen_Shot_2020-09-04_at_1.42.30_PM Screen_Shot_2020-09-04_at_1.42.12_PM

Instructions

  • Using the migration script, or by manually editing the files:
    • Replace each instance of <gl-deprecated-button> with <gl-button>.
    • Convert each variant attribute to the new variant/category combination using the variant mapping guide.
  • Take before/after screenshots of each button in the file, and upload them in the Merge Request description.
  • Request review from a designer within your stage group. If you are outside of a stage group, ping a UX foundations member.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jarek Ostrowski

Merge request reports

Loading