Skip to content

Fix(mergeUrlparams): handle arrays gracefully

What does this MR do?

This MR adds an option parameter to mergeUrlParams to spread array values into separate URL parameters.

Array parameters would before be combined into a single string rather than individual sets of key/value-pairs, which is necessary in some situations.

This will be used in this MR to handle url-sync'ing from nested components.

Screenshots

spreadArrays=false spreadArrays=true
Screen_Shot_2020-08-17_at_18.07.03 Screen_Shot_2020-08-17_at_18.06.35

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This adds an option that will be used in a successive MR and other usages that need this behavior on an opt-in basis and will be unchanged otherwise. This MR, therefore, comes with very little risk.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #232465 (closed)

Related to !39603 (merged)

Edited by Michael Lunøe

Merge request reports

Loading