Skip to content

Replace Bootstrap Button & LoadingButton w/ GitLab UI GlButton in vulnerability_action_buttons.vue

What does this MR do?

Replaces instances of Bootstrap Button & LoadingButton components with GitLab UI GlButton component to improve performance of our application & ensure consistency across the GitLab UI.

Screenshots

Type Before After
Zoom image Screen_Shot_2020-08-18_at_4.13.00_PM

NOTE - the difference in border color was reviewed by our UX counterpart @andyvolpe & signed off on in this comment. The Secondary GlButton component does not support the previous gray border color for the success, info, and warning variants we're using.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Issues: #229297 (closed) #229217 (closed)

Edited by Lindsay Kerr

Merge request reports

Loading