Improve file-by-file navigation
What does this MR do?
For #228909 (closed)
There are three main changes in this MR:
- Replaces the button / button group with the
GlPagination
component - Adds labeling text below the pagination component to show the current file and the total number of files
- Removes all of the file-by-file navigation (pagination + labeling text) when there are fewer than 2 files.
Screenshots
Scenario | Image |
---|---|
First file | |
Middle file | |
Last file | |
Single file, no nav |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph