Skip to content

Replace some fa-circle icons with GitLab SVG check icon

Martin Wortschack requested to merge mw-replace-circle-icon into master

What does this MR do?

This MR replaces some of the Fontawesome fa-circle icons with the Gitlab check SVG.

Screenshots

Page Before After
Gitaly servers (http://gdk.test:3000/admin/gitaly_servers) gitaly_servers_before gitaly_servers_after
Service templates (http://gdk.test:3000/admin/application_settings/services) service_templates_before service_templates_after
Project integrations (http://gdk.test:3000/gitlab-org/gitlab-test/-/settings/integrations) project_integrations_before project_integrations_after
Admin health check (http://gdk.test:3000/admin/health_check) admin_health_check_before admin_health_check_after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Relates to #225923 (closed)

Edited by Martin Wortschack

Merge request reports

Loading