Replace fa-remove with SVG close icons
What does this MR do?
Replaces fa-remove
icons with GitLab SVG clear
icons.
Screenshots
Admin/runners
https://gdk.test:3443/admin/runners
Before | After |
---|---|
Pipeline/jobs
https://gdk.test:3443/h5bp/html5-boilerplate/-/jobs
Before | After |
---|---|
Group/runners
https://gdk.test:3443/groups/h5bp/-/settings/ci_cd
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #225906 (closed)
Edited by Jiaan Louw