Skip to content

Draft: Align Draft Merge Request Regex Behaviour

Jamie Reid requested to merge update-mr-draft-regex into master

What does this MR do?

The front-end regex that marks an MR as draft (in issuable_form.js) does not match the back-end regex (in regex.rb), and the docs were also inconsistent with behaviour.

This MR attempts to align all three in their marking of an MR as draft and updates the specs for both MRs and commits, with the goal of matching as closely as possible the functionality as-currently-documented.

Closes #238967 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • N/A Label as security and @ mention @gitlab-com/gl-security/appsec
  • N/A The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • N/A Security reports checked/validated by a reviewer from the AppSec team
Edited by Marcel Amirault

Merge request reports

Loading