Skip to content

Report correct shared examples location

Mark Lapierre requested to merge ml-report-correct-shared-examples-location into master

What does this MR do?

This fix makes the JSON formatter report the path the spec file that includes the shared examples. The line number is the line in that spec file that refers to the shared examples.

Previously shared examples would cause NoMethodError undefined method [] for nil:NilClass as in https://gitlab.com/gitlab-org/quality/nightly/-/jobs/696820588

Part of https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/504

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mark Lapierre

Merge request reports

Loading