Skip to content

Remove overwrite param on propagate integrations

Arturo Herrero requested to merge remove-overwrite-on-propagate-integrations into master

What does this MR do?

In !32331 (merged), we introduced the propagation of the instance-level services. Initially, we developed the functionality to propagate integration settings to all projects, but we are not going to use that option.

This removes the overwrite parameter and the propagation functionality to all projects.

On the frontend side, we haven't implemented that option yet and the overwrite parameter is not permitted because it wasn't included on the list, see https://gitlab.com/gitlab-org/gitlab/-/blob/v13.3.0-ee/app/controllers/concerns/service_params.rb#L6-71. So, the coercion of the missing argument giving us overwrite: false which is want we want #238628 (comment 399639746).

We are using Sidekiq, so we cannot completely remove the parameter until the next major release. https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#remove-an-argument

This work simplifies and helps in the preparation for the upcoming work to extend the propagation to group-level integrations #209831 (closed).

Related to #199388 (closed) and #209831 (closed).

Edited by Arturo Herrero

Merge request reports