Skip to content

Fix snowplow tracking event error for new user invite page

Nicolas Dular requested to merge nicolasdular/fix-invite-mail-tracking into master

What does this MR do?

References: #241727 (closed)

Introduced by !39628 (merged)

The value property on Snowplow only accepts Numbers or nil values. This caused an issue for the invitation event where we're using a string for value. We're fixing the problem by using the label property instead which accepts Strings as well.

See snowplow docs for details on the types: https://github.com/snowplow/snowplow/wiki/snowplow-tracker-protocol#39-custom-structured-event-tracking

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading