Extract complex view logic into helper methods
What does this MR do?
This MR is a follow-up to work done in !40304 (merged), as mentioned in this comment & this comment.
As part of the effort to fix the ~bug that !40304 (merged) was targeting, it became clear that some of the logic in the welcome view was overly complex and should be refactored into a couple of helper methods. This MR achieves that goal.
No changelog is necessary as this is a purely developer-facing change. Likewise, this change does not alter anything which requires updated documentation.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Slightly related to #240917 (closed) & !40504 (merged); depends on some of the added logic from !40304 (merged)