Skip to content

Add snowplow spec helper

Nicolas Dular requested to merge nicolasdular/snowplow-spec-helper into master

What does this MR do?

This is inspired by the discussion in #238552 (closed) and the draft MR !40646 (closed) to improve snowplow testing.

The reasoning:

  1. An severity1 MR to fix a bug related to Snowplow because of mismatched types !39725 (merged)
  2. An severity4 MR to fix a bug related to Snowplow because of mismatched types !40628 (merged)

Both MRs could have been prevented if we actually call Snowplow instead of just mocking Gitlab::Tracking.

This is the first iteration to improve the specs around snowplow. As a follow-up iteration, we could also think about not mocking Gitlab::Tracking anymore but actually checking the requests from webmock.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading