Add scanner profiles to DAST on-demand profiles library view
requested to merge 233453-dast-scanner-profile-library-implementation-iteration-1-add-scanner-profiles-to-library-view into master
What does this MR do?
It adds the "Scanner Profiles" tab to the DAST on-demand scanner library.
Note: Both the "Edit" and "Delete" actions are currently not fully functional and require some backend work to be finished. But the change is behind a auto-disabled feature flag, so this should not be a problem.
Local testing:
- Enable feature flag:
echo "Feature.enable(:security_on_demand_scans_scanner_profiles)" | spring rails c
- Navigate to on-demand scanner profile page:
http://localhost:3000/{grou}/{project}/-/on_demand_scans/profiles
e.g: http://localhost:3000/h5bp/html5-boilerplate/-/on_demand_scans/profiles
- If you want to add some scanner profiles locally you can use @djadmin 's WIP branch, which adds the related form: https://gitlab.com/gitlab-org/gitlab/-/tree/djadmin-scanner-profile-form - the form is accessible via the "New Site Profile" link on the library view page.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #233453 (closed)
Edited by David Pisek