Refactor VSA api request to take a parameter
What does this MR do?
Refactors some of the VSA api routes to take an object as their parameter
Based on the discussion from !38029 (merged) :
-
@ekigbo started a discussion: (+3 comments) Just cleaned up the order of the parameters so they follow the logical order they appear in the url (a few more below). I thought about making these an object, but i dont think they will change again for a while so probably
🆗 as i
Screenshots
No visual changes
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #233134 (closed)
Edited by Ezekiel Kigbo