Skip to content

Replace LoadingButton with GlButton for the comment dismissal modal

Libor Vanc requested to merge 229214-replace-LoadingButton-with-GlButton into master

What does this MR do?

Resolve "Replace LoadingButton with GitLab UI’s GlButton in ee/app/assets/javascripts/vue_shared/security_reports/components/dismissal_comment_modal_footer.vue"

Screenshots

Before After
2020-09-01_17-04-52 2020-09-01_17-07-37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #229214 (closed)

Edited by Martin Wortschack

Merge request reports

Loading