Skip to content

Add dynamic filters for scanner/vendor

Alexander Turinske requested to merge 210327-update-project-filters-v3 into master

What does this MR do?

Add ability for dynamic filters for reportType/scanner

Users can configure independent 3rd-party scanners and this MR dynamically generates those filters. It always creates the GitLab filters we all know and love, but then creates independent filters (i.e. Dast - custom scanner this means that now when a user selects a reportType filter (what we call Scanner in the UI), it is not just the reportType being searched for (i.e. DAST, SAST, etcetera), but also the scanner itself (i.e. Gemnasium, custom-scanner-dast, etcetera), so the reportType filter is now two filters in one.

To achieve this, I must first retrieve the project-specific filters, and create the filter options, and then make it so when the user selects one of the filters, it searches by both reportType and scanner

Screenshots

DEMO
https://www.youtube.com/watch?v=HNOwyGJy-Wc&feature=youtu.be

NOTE: The checkmarks are not correct in the second image; only one should be selected.

- Before After
- Screen_Shot_2020-08-31_at_4.42.37_PM default
- Screen_Shot_2020-08-31_at_4.42.47_PM selection

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #229661 (closed)

Edited by Alexander Turinske

Merge request reports

Loading