Skip to content

UI VSA delete value stream

Ezekiel Kigbo requested to merge 221205-delete-value-stream-mvc-fe into master

What does this MR do?

This MR requires the API endpoint added in !41057 (merged)

Adds the relevant UI changes for deleting a value stream

  • Allows deletion of any custom value stream
  • Updated specs for the value_stream_select component

Screenshots

Default value stream selected Custom value stream Delete confirmation Deleted With an error
Screen_Shot_2020-09-02_at_4.11.56_pm Screen_Shot_2020-09-02_at_4.11.43_pm Screen_Shot_2020-09-02_at_4.12.18_pm Screen_Shot_2020-09-02_at_4.12.33_pm Screen_Shot_2020-09-09_at_1.17.55_am

Testing

  1. Enable value_stream_analytics_create_multiple_value_streams
  2. Browse to group VSA, for example /groups/gitlab-org/-/analytics/value_stream_analytics
  3. The Click Create new value stream button from the dropdown next to the title to create a value stream
  4. Refresh the page and select your new value stream
  5. Open the dropdown and scroll to the bottom to see a button to delete the currently selected value stream (except for default)
  6. Click the delete button and confirm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #221205 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading