Create Issues::CreateFromVulnerabilityService
What does this MR do?
Introduces Issues::CreateFromVulnerabilityService
which will allow us not to pass unnecessary data from frontend to backend when creating Issues from Vulnerabilities.
Up until now we have been using Issues::CreateFromVulnerabilityDataService
which is designed to create Issues from Vulnerabiliites::Finding
objects which might not be persisted in the database. When we introduced Standalone Vulnerabilities this lead into a weird circle where backend passed the vulnerability data to the frontend to present, which in turn sent them back to the backend to create an issue to investigate that vulnerability.
See #223142 (closed) and #214474 (closed) for whole context.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team