Follow-up on "Feat(Analytics filter module): lists + values"
What does this MR do?
This MR fixes an issue where the URL parameters were not being processed correctly on the Value Stream Analytics (aka. Cycle Analytics) page after this MR merged: !40845 (merged).
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
You can test this out by navigating to these two links:
- http://127.0.0.1:3000/groups/flightjs/-/analytics/value_stream_analytics?created_after=2020-08-03&created_before=2020-09-01&milestone_title=Any&author_username=Any&label_name[]=Accord&label_name[]=Brynce&assignee_username[]=Any
- https://staging.gitlab.com/groups/gitlab-com/-/analytics/value_stream_analytics?created_after=2020-08-03&created_before=2020-09-01&milestone_title=Any&author_username=Any&label_name[]=Accord&label_name[]=Brynce&assignee_username[]=Any
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related MR: !40845 (merged)
Edited by Michael Lunøe