VSA Add stage button doesnt display the form
What does this MR do?
In !38447 (merged) the showAddStageForm
event was renamed to show-add-stage-form
to fix a eslint warning (vue/custom-event-name-casing) but the listener was not updated to reflect this.
Additionally the VSA (cycle analytics) spec was accidentally removed in !39368 (merged) which would explain why this wasnt caught.
Fixes display of the custom stage form
- Moves the event to
STAGE_ACTIONS
for consistency with the other events - Adds additional jest specs
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #244054 (closed)
Closes #244054 (closed)
Edited by Ezekiel Kigbo