Skip to content

VSA Add stage button doesnt display the form

What does this MR do?

In !38447 (merged) the showAddStageForm event was renamed to show-add-stage-form to fix a eslint warning (vue/custom-event-name-casing) but the listener was not updated to reflect this.

Additionally the VSA (cycle analytics) spec was accidentally removed in !39368 (merged) which would explain why this wasnt caught.

Fixes display of the custom stage form

  • Moves the event to STAGE_ACTIONS for consistency with the other events
  • Adds additional jest specs

Screenshots

Screen_Shot_2020-09-02_at_10.01.55_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #244054 (closed)

Closes #244054 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading