Skip to content

Restore doorkeeper generator to hex due to breaking change

Drew Blessing requested to merge dblessing-doorkeeper-hex-generator into master

What does this MR do?

Related to #244371 (closed)

Doorkeeper 5.1 changed the default token generator to urlsafe_base64 from hex. This restores the generator to hex to avoid the breaking change. https://github.com/doorkeeper-gem/doorkeeper/wiki/Migration-from-old-versions#api-changes-4

Screenshots

It's a little difficult to see here, but you can tell the values are different format.

Before

Screen_Shot_2020-09-02_at_12.21.41_PM

After

Screen_Shot_2020-09-02_at_12.18.48_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports

Loading