Replace v-html with v-safe-html in recaptcha_modal.vue
What does this MR do?
This MR replaces v-html
with v-safe-html
in app/assets/javascripts/vue_shared/components/recaptcha_modal.vue
.
Relates to #241965 (closed).
Steps to test
I don't know how to provoke the reCAPTCHA model, so I replaced the data
in app/assets/javascripts/vue_shared/mixins/recaptcha_modal_implementor.js
with:
data() {
return {
showRecaptcha: true,
recaptchaHTML: '<b onload=alert(1)>test html for recaptcha</b>',
};
},
Then I visited an issue. And with the changes the unsafe property is removed.
BUT since I'm not sure how the current version of Google's reCAPTCHA works, it might break it.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev