Backport expire_at from carrierwave 2.1.* to patch
What does this MR do?
We want to use custom expire_at for pages object storage links to make them valid for longer(24 hours). These links won't be exposed to end users, and will be used by pages only
See !40361 (comment 401848949)
Since this method is patched in gitlab codebase, we need to also backport https://github.com/carrierwaveuploader/carrierwave/commit/64aab24f57e4e1f7489e9faa37d6782818c164cc
Part of #238986 (closed)
This can be safely removed once we update carrierwave to > 2.1.0
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński (Back 2025-01-01)