Migrate Bootstrap dropdown to GitLab UI GlDropdown in pikaday.vue
requested to merge nuwe1/gitlab:Migrate-Bootstrap-dropdown-to-GitLab-UI-GlDropdown-in-app/assets/javascripts/vue_shared/components/pikaday.vue into master
What does this MR do?
This MR is Migrate Bootstrap dropdown to GitLab UI GlDropdown in app/assets/javascripts/vue_shared/components/pikaday.vue and closes this #235372 (closed) issue
Screenshots
| Before | After |
|---|---|
| cell | cell |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Marvin Karegyeya