Skip to content

Add locationHash support to DAST scanner-profile library

What does this MR do?

It adds support for linking directly to a profile tab (site- , or scanner profile) within the DAST on-demand scanner-profile library by setting a location hash to either #site-profiles or #scanner-profiles.

Local testing:

  1. Enable feature flag:
echo "Feature.enable(:security_on_demand_scans_scanner_profiles)" | spring rails c
  1. Navigate to on-demand scanner profile page:

http://localhost:3000/{grou}/{project}/-/on_demand_scans/profiles e.g: http://localhost:3000/h5bp/html5-boilerplate/-/on_demand_scans/profiles

  1. Append both #site-profiles or #scanner-profiles to the URL and refresh the page. The respective tab should be selected

  2. Change a tab by clicking on it. The URL should be updated to contain the tab's hash.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #233453 (closed)

Edited by David Pisek

Merge request reports

Loading