Skip to content

Stop exposing Flash on window Object

Lukas Eipert requested to merge leipert-remove-flash-window into master

What does this MR do?

Stop exposing Flash on window Object

Adding APIs to the window object is problematic due to side effects and needing to make sure that the API is loaded. It makes it harder to reason about where a file is used and how to refactor it.

This moves the remaining window.Flash usages to direct imports.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports

Loading