Skip to content

Move pipeline lint warnings to Vue

Payton Burdette requested to merge move-pipeline-warnings-to-vue into master

What does this MR do?

This MR moves over the pipeline lint warnings to the Vue implementation of the Run pipeline view. During this move, I've also made the pipeline warnings now dismissible. As well as changed the pipelines controller JSON response to include the pipeline warnings.

Currently we don't have a smart way on the Vue side of things to parse markdown and find links, so since this is an MVC, the links are just plain text for now.

Screenshots

Screen_Shot_2020-09-08_at_5.19.27_PM

Screen_Shot_2020-09-08_at_5.20.24_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports

Loading