Skip to content

Pass log level explicitly when building Gitlab::Logger

Peter Leitzen requested to merge pl-gitlab-logger-level-debug-explicit into master

What does this MR do?

Note, the log level of Ruby's Logger defaults to DEBUG https://ruby-doc.org/stdlib-2.6.6/libdoc/logger/rdoc/Logger.html so we are not changing the log level but making it extra clear that the choice of the log level is intentional and not configurable for structured logging (yet).

Refs #247092 (comment 410387157)

Verification

Gitlab::Kubernetes::Logger.build.level == Logger::DEBUG # => true

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading