Remove instance level Value Stream Analytics code
What does this MR do?
Solves #230632 (closed)
This MR eliminates global level analytics features which have been already hidden from the UI for quite some time. Some code had to be moved to the group level where previously we had inheritance or simply code duplication.
The MR is quite big, however we're just mostly moving code from the global level to the group level (controllers/analytics -> controllers/groups/analytics).
-
ee/app/controllers/analytics/application_controller.rb
: Deleted, content was already duplicated inee/app/controllers/groups/analytics/application_controller.rb
-
ee/app/controllers/analytics/cycle_analytics/stages_controller.rb
->ee/app/controllers/groups/analytics/cycle_analytics/stages_controller.rb
-
ee/app/controllers/analytics/cycle_analytics/summary_controller.rb
->ee/app/controllers/groups/analytics/cycle_analytics/summary_controller.rb
-
ee/app/controllers/analytics/cycle_analytics_controller.rb
->ee/app/controllers/groups/analytics/cycle_analytics_controller.rb
-
ee/app/controllers/analytics/productivity_analytics_controller.rb
: Deleted, content was already duplicated inee/app/controllers/groups/analytics/productivity_analytics_controller.rb
-
ee/app/controllers/analytics/tasks_by_type_controller.rb
->ee/app/controllers/groups/analytics/tasks_by_type_controller.rb
Note: The change is not affecting the users.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi