Skip to content

Made MR Popovers bundle load conditionally

Tim Zallmann requested to merge tz-load-mr-popovers-conditional into master

What does this MR do?

This loads now the MR popover only when actually MR Popover links are rendered. This should reduce the main.js by a lot as this removes bigger libraries. As you can see we have now a 19% reduction in main.js

It also moves the render move into a requestIdleCallback to reduce the rendering pressure right away.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports

Loading