Fix "Asset was not declared to be precompiled in production" error with favicon-green.ico
What does this MR do?
Fix Asset was not declared to be precompiled in production
500 error with favicon-green.ico
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Using the latest EE master
would cause the page to 500.
When running the latest EE
master
, the following 500 error occurs when visiting a page.Asset was not declared to be precompiled in production. Add `Rails.application.config.assets.precompile += %w( favicon-green.ico )` to `config/initializers/assets.rb` and restart your server
In relation to this line from app/views/layouts/_head.html.haml:28
= favicon_link_tag favicon, id: 'favicon'
It looks like
favicon-green.ico
change was introduced in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4129
app/assets/images/favicon-green.ico
→ee/app/assets/images/favicon-green.ico
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary- Fixed in same release it was introduced
-
Tests added for this feature/bug- Possible to test?
- Review
-
Has been reviewed by Backend
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
What are the relevant issue numbers?
Closes #4666 (closed)