Skip to content

Report BatchNotResetError to Sentry only after retries

Fabio Pitino requested to merge report-ci-minutes-reset-error-after-retries into master

What does this MR do?

Related to Related to #243762 (closed).

This is a follow-up MR from !41888 (comment 410760338) where we send information to Sentry about the exception been raised.

In the previous MR we were over-reporting to Sentry. E.g. when a batch failed with a statement timeout but worked on retry, we would still report the exception to Sentry, adding noise to bug investigations.

With this MR only one report will be sent to Sentry, containing data about failing batches and not each time an error is rescued. This removes noise from Sentry when a worker succeeds on retry.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading